MINOR: Don't install Homebrew's aws-sdk-cpp and gRPC for JNI macOS build - #1269
Merged
Merged
Conversation
The "JNI macos-15-intel x86_64" job fails in "Install dependencies":
##[error]aws-sdk-cpp: no bottle available!
##[error]grpc: no bottle available!
`brew bundle` failed! 2 Brewfile dependencies failed to install
Homebrew treats x86_64 macOS as a tier 3 configuration and rarely
publishes bottles for it. "brew bundle" doesn't build from source, so
arrow/cpp/Brewfile can no longer be installed as-is.
We don't use Homebrew's aws-sdk-cpp and gRPC anyway. The JNI build uses
ARROW_DEPENDENCY_USE_SHARED=OFF and Homebrew provides only shared
libraries for them, so we uninstall both just after "brew bundle". We
skip installing them with HOMEBREW_BUNDLE_BREW_SKIP instead of
installing and uninstalling them.
"brew uninstall aws-sdk-cpp" needs "|| :" now because it's no longer
installed by "brew bundle". It's still called because it may be
pre-installed on GitHub Actions runner images.
jbonofre
requested review from
kou,
laurentgo,
lidavidm and
wgtmac
as code owners
August 28, 2026 13:22
Member
Author
|
@lidavidm this PR is about a CI failure I observed. |
lidavidm
approved these changes
Aug 28, 2026
kou
pushed a commit
that referenced
this pull request
Aug 31, 2026
The `JNI macos-15-intel x86_64` job currently fails on `main` and on every open PR while installing dependencies: ``` ==> Installing node Error: node: no bottle available! This is a Tier 3 configuration: https://docs.brew.sh/Support-Tiers#tier-3 Installing node has failed! `brew bundle` failed! 1 Brewfile dependency failed to install ``` `apache/arrow`'s `cpp/Brewfile` lists `brew "node"`, and Homebrew treats x86_64 macOS as a tier 3 configuration and no longer builds a bottle for it. `brew bundle` doesn't build from source, so the step aborts before anything is built. We don't need Node.js for the JNI build, so this skips installing it via `HOMEBREW_BUNDLE_BREW_SKIP`, the same way #1269 did for `aws-sdk-cpp` and gRPC. Failing runs for reference: * `main`: https://github.com/apache/arrow-java/actions/runs/33283736388/job/99183221397 * PR #1263: https://github.com/apache/arrow-java/actions/runs/33297775855/job/99221106761
This was referenced Sep 21, 2026
kou
pushed a commit
that referenced
this pull request
Sep 21, 2026
### Rationale for this change Homebrew treats x86_64 macOS as a [tier 3 configuration](https://docs.brew.sh/Support-Tiers#tier-3) and rarely builds bottles for it. `brew bundle` doesn't build from source, so the `JNI macos-15-intel x86_64` job in the RC workflow aborts in `Install dependencies` with `no bottle available!` before anything is compiled. We've been patching this formula by formula: * #1269 skipped `aws-sdk-cpp` and gRPC. * #1270 skipped Node.js. Any new dependency added to `apache/arrow`'s `cpp/Brewfile` can break the job again the same way, and nightly RC runs go red on `main` when it does. We can't keep this job green on a configuration Homebrew doesn't support. #1269 noted that dropping the `macos-15-intel` entry needed its own discussion because it's user-facing. #1305 is that discussion. ### What changes are included in this PR? `rc.yml`: * Removed the `macos-15-intel` / `x86_64` entry from the `jni-macos` matrix. * `binaries` no longer extracts `jni-macos-x86_64.tar.gz` nor asserts the four `jni/*/x86_64/*.dylib` files. * Dropped the `/usr/local` `python@XXX --overwrite` conflict loop. Its comment already said it could go once we dropped `macos-15-intel`, since `macos-14` and later on arm64 use `/opt/homebrew`. `brew update` is kept. * Unwrapped the `pkg-config` uninstall from its `if [ "$(uname -m)" = "arm64" ]` guard, which is now always true. * Trimmed the tier-3 justification from the `HOMEBREW_BUNDLE_BREW_SKIP` comment. The skip list itself is unchanged: `aws-sdk-cpp` and gRPC are still skipped so the bundled static ones are used, and Node.js is still skipped because the JNI build doesn't need it. `test.yml`: * Removed the `AMD64` / `macos-15-intel` entry from the `macos` test matrix, leaving `AArch64` on `macos-latest`. `ci/scripts/jni_macos_build.sh` is untouched, so building the JNI libraries locally on an Intel Mac still works. ### Are these changes tested? Yes, by CI. The remaining `JNI macos-14 aarch_64` job exercises the changed `Install dependencies` step, and `binaries` exercises the changed artifact extraction and verification. ### Are there any user-facing changes? Yes. Release JARs no longer bundle x86_64 macOS `.dylib` files for `arrow_cdata_jni`, `arrow_dataset_jni`, `arrow_orc_jni` and `gandiva_jni`. Intel Mac users of those modules will need to build the JNI libraries themselves. aarch64 macOS, x86_64 and aarch64 Linux, and x86_64 Windows are unaffected. Closes #1305.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
The
JNI macos-15-intel x86_64job in the RC workflow fails inInstall dependencies, before anything is built:Homebrew treats x86_64 macOS as a tier 3 configuration and rarely publishes bottles for it.
brew bundledoesn't build from source, soarrow/cpp/Brewfilecan no longer be installed as-is there.This breaks
maintoo, not just PRs, so nightly RC runs are red.What changes are included in this PR?
We don't use Homebrew's
aws-sdk-cppand gRPC anyway:ninja-release-jni-macospreset, which setsARROW_DEPENDENCY_USE_SHARED=OFF.aws-sdk-cppand gRPC.brew bundleto ensure the bundled ones are used.We skip installing them with
HOMEBREW_BUNDLE_BREW_SKIPinstead of installing and uninstalling them. This also makes themacos-14aarch_64job a bit faster because it no longer installs two formulae it immediately removes.brew uninstall aws-sdk-cppneeds|| :now because it's no longer installed bybrew bundle. It's still called because it may be pre-installed on GitHub Actions runner images.Note that this keeps building the x86_64 macOS shared libraries. Dropping the
macos-15-intelentry would remove.dylibfiles for x86_64 macOS from our release JARs, which needs a separate discussion.Are these changes tested?
Yes, by CI. The
JNI macos-15-intel x86_64andJNI macos-14 aarch_64jobs in this PR exercise the changed step.Are there any user-facing changes?
No.