Revert "chore: formalize the default map field names to match default arrow spec (#10297)" - #10506
Merged
Merged
Conversation
… arrow spec (apache#10297)" This reverts commit b963ecf.
github-actions
Bot
added
parquet
This was referenced Jul 31, 2026
alamb
marked this pull request as ready for review
July 31, 2026 20:44
Jefffrey
approved these changes
Aug 1, 2026
14 tasks
Contributor
Contributor
Author
|
Thanks @Jefffrey I made a PR to reapply the changes while it is fresh in my mind |
Jefffrey
added a commit
that referenced
this pull request
Aug 4, 2026
…0517) This reverts commit ed92960. # Which issue does this PR close? - related to #10506 - related to #10297 # Rationale for this change As part of the 59.2.0 release, I found that the changes in #10297 from @rluvaton required downstream modifications and thus were not appropriate for a point release. Thus I reverted the changes in #10506 until the next breaking release (60.0.0) # What changes are included in this PR? - Reapplies the changes from #10297 - (by reverting the revert from #10506 🤯 ) # Are these changes tested? Yes # Are there any user-facing changes? Yes, the names of fields in MapArrays are now consistent ("key" and "value" always, rather than sometimes "keys" and "values") Co-authored-by: Jeffrey Vo <jeffrey.vo.australia@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
N/A
cc @Jefffrey and @rluvaton
Rationale for this change
#10297 changed the default map field names from
keys/valuestokey/valueto match the Arrow spec. This is a good change to align with the spec, but it is a breaking change: it broke the DataFusion upgrade (apache/datafusion#24030) because data produced elsewhere (e.g. by other Arrow implementations) uses the oldkeys/valuesfield names, causing schema mismatches such as:See discussion on #10297: #10297 (comment)
We should hold the field name change for the next breaking release to minimize downstream churn on a minor release, rather than ship it in a minor release.
What changes are included in this PR?
keys/values(plural).Are these changes tested?
Existing tests.
Are there any user-facing changes?
Yes: this reverts the default
MapFieldNamesback tokeys/values(as it was prior to #10297), rather thankey/value. The intent is to reapply #10297 as part of the next breaking release.