-
Notifications
You must be signed in to change notification settings - Fork 1.1k
feat: change default behavior for Parquet PageEncodingStats to bitmask
#9051
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: change default behavior for Parquet PageEncodingStats to bitmask
#9051
Conversation
|
run benchmark metadata |
|
🤖 |
|
🤖: Benchmark completed Details
|
etseidl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @WaterWhisperer, this looks good to me. I think we should also modify the benchmark to use the old behavior for the baseline benchmarks, or remove the 'PES' benches which are now redundant.
3a58d23 to
248b7eb
Compare
|
@etseidl could you have one more look at the PR? |
|
run benchmark metadata |
|
🤖 |
|
🤖: Benchmark completed Details
|
Which issue does this PR close?
PageEncodingStats#8859Rationale for this change
What changes are included in this PR?
DefaultforParquetMetaDataOptionswithencoding_stats_as_mask: trueAre these changes tested?
Yes
Are there any user-facing changes?
Yes