Alamb/test bin op5 #9074
Closed
Alamb/test bin op5 #9074
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
parquet
Contributor
Author
|
run benchmark boolean_kernels |
|
🤖 |
|
🤖: Benchmark completed Details
|
alamb
force-pushed
the
alamb/test_bin_op5
branch
from
0c17b73 to
3f6f23b
Compare
alamb
commented
Dec 31, 2025
arrow-select/src/nullif.rs
Outdated
| .into_inner(); | ||
| (buffer, null_count) | ||
| } | ||
| let combined = if let Some(left) = left_data.nulls() { |
Contributor
Author
There was a problem hiding this comment.
Since the new optimized from_bitwise_binary_op may call op outside of the set bits, we need to avoid also trying to count the ones within the first pass.
Contributor
Author
There was a problem hiding this comment.
Note to self: I made a nullif benchmark locally, and it seems as if counting bits during the application actually does make a small difference
nullif no-nulls mask(10%)
time: [208.47 ns 209.97 ns 211.22 ns]
change: [+6.4142% +7.1611% +7.9491%] (p = 0.00 < 0.05)
Performance has regressed.
Found 11 outliers among 100 measurements (11.00%)
6 (6.00%) low severe
2 (2.00%) low mild
2 (2.00%) high mild
1 (1.00%) high severe
nullif no-nulls mask(10%, sliced)
time: [242.71 ns 244.30 ns 245.68 ns]
change: [+4.9678% +5.8756% +6.8006%] (p = 0.00 < 0.05)
Performance has regressed.
Found 9 outliers among 100 measurements (9.00%)
6 (6.00%) low severe
3 (3.00%) low mild
nullif no-nulls mask(1%)
time: [220.58 ns 222.91 ns 225.16 ns]
change: [+10.834% +12.034% +13.361%] (p = 0.00 < 0.05)
Performance has regressed.
Found 10 outliers among 100 measurements (10.00%)
7 (7.00%) low severe
2 (2.00%) low mild
1 (1.00%) high severe
nullif nulls mask(10%) time: [213.91 ns 215.16 ns 216.23 ns]
change: [+4.9421% +5.7045% +6.4951%] (p = 0.00 < 0.05)
Performance has regressed.
Found 10 outliers among 100 measurements (10.00%)
4 (4.00%) low severe
6 (6.00%) low mild
nullif nulls mask(10%, sliced)
time: [253.58 ns 255.72 ns 257.57 ns]
change: [+3.2081% +4.1105% +4.9077%] (p = 0.00 < 0.05)
Performance has regressed.
Found 10 outliers among 100 measurements (10.00%)
6 (6.00%) low severe
4 (4.00%) low mild
nullif nulls mask(1%) time: [224.66 ns 226.45 ns 227.95 ns]
change: [+7.8770% +8.8461% +9.8628%] (p = 0.00 < 0.05)
Performance has regressed.
Found 12 outliers among 100 measurements (12.00%)
7 (7.00%) low severe
5 (5.00%) low mild
Contributor
Author
|
Broken into other prs Closing this PR in favor of #9090 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?