Closed
Conversation
Contributor
hhhizzz
reviewed
Mar 4, 2026
| ) -> ReadPlanBuilder { | ||
| // override only applies to Auto policy, If the policy is already Mask or Selectors, respect that | ||
| let RowSelectionPolicy::Auto { .. } = plan_builder.row_selection_policy() else { | ||
| // If the policy is already Selectors, no override is needed |
Contributor
There was a problem hiding this comment.
I remember our design here is to respect the user’s configuration. If they choose mask, they should face the risk that the program may fail, rather than the program implicitly changing the setting to selector.
Contributor
Author
|
OK I've raised a PR to actually address the underlying cause, but I feel like this whole behaviour is extremely brittle and probably worth a stab at coming up with a better design: #9509 Closing this PR in favour |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
None, but we are seeing this in production
Rationale for this change
There is a mismatch between some configuration options that cause this test to fail.
What changes are included in this PR?
Adds some changes to
override_selector_strategy_if_neededAre these changes tested?
Yes, a new test is written that fails on
mainAre there any user-facing changes?
Nope