chore: pin comfy-table to 7.2.1 to respect our MSRV#9501
Draft
rtyler wants to merge 1 commit intoapache:mainfrom
Draft
chore: pin comfy-table to 7.2.1 to respect our MSRV#9501rtyler wants to merge 1 commit intoapache:mainfrom
rtyler wants to merge 1 commit intoapache:mainfrom
Conversation
Member
|
Given the fact that we are on edition 2024, I suggest we bump In this way, we don't need to pin dep versions anymore. |
rtyler
added a commit
to buoyant-data/delta-kernel-rs
that referenced
this pull request
Mar 4, 2026
Regrettably there are a host of of MSRV issues and incompatibilities that pop out of the woodwork with object_store 0.13. There are transitive dependencies down the stack that make it impossible to incorporate arrow 58 without _at least_ a MSRV of Rust 1.88. Relatedly, arrow also got sniped by some transitive dependency issues: apache/arrow-rs#9501 Signed-off-by: R. Tyler Croy <rtyler@brokenco.de>
The 7.2.2 release of comfy-table results in the build no longer being compatible with Rust 1.85. This change pins that restriction and ensures that CI is testing with our minimum version instead of the latest stable Signed-off-by: R. Tyler Croy <rtyler@brokenco.de>
rtyler
added a commit
to buoyant-data/delta-kernel-rs
that referenced
this pull request
Mar 5, 2026
Regrettably there are a host of of MSRV issues and incompatibilities that pop out of the woodwork with object_store 0.13. There are transitive dependencies down the stack that make it impossible to incorporate arrow 58 without _at least_ a MSRV of Rust 1.88. Relatedly, arrow also got sniped by some transitive dependency issues: apache/arrow-rs#9501 Signed-off-by: R. Tyler Croy <rtyler@brokenco.de>
rtyler
added a commit
to buoyant-data/delta-kernel-rs
that referenced
this pull request
Mar 5, 2026
Regrettably there are a host of of MSRV issues and incompatibilities that pop out of the woodwork with object_store 0.13. There are transitive dependencies down the stack that make it impossible to incorporate arrow 58 without _at least_ a MSRV of Rust 1.88. Relatedly, arrow also got sniped by some transitive dependency issues: apache/arrow-rs#9501 Signed-off-by: R. Tyler Croy <rtyler@brokenco.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
What changes are included in this PR?
The 7.2.2 release of comfy-table results in the build no longer being compatible with Rust 1.85. This change pins that restriction and ensures that CI is testing with our minimum version instead of the latest stable
Are these changes tested?
cargo build
Are there any user-facing changes?
This broke some delta-kernel-rs builds when upgrading to 58