fix: first next_back() on new RowsIter panics#9505
Open
rluvaton wants to merge 1 commit intoapache:mainfrom
Open
fix: first next_back() on new RowsIter panics#9505rluvaton wants to merge 1 commit intoapache:mainfrom
rluvaton wants to merge 1 commit intoapache:mainfrom
Conversation
scovich
reviewed
Mar 5, 2026
Contributor
scovich
left a comment
scovich
left a comment
There was a problem hiding this comment.
I'm not familiar with the row API, but this seems like a simple off-by-one error?
Comment on lines
+1418
to
1419
| let row = unsafe { self.rows.row_unchecked(self.end - 1) }; | ||
| self.end -= 1; |
Contributor
There was a problem hiding this comment.
Should we just move the self.end decrement above the original unsafe block?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
N/A
Rationale for this change
it should not panic
What changes are included in this PR?
correctly use last row in
next_backAre these changes tested?
yes
Are there any user-facing changes?
they can now use
next_back