Skip to content

[C++][Parquet] Mark MakeStatistics without ColumnDescriptor as deprecated #50737

Description

@HuaHuaY

Describe the bug, including details regarding any error messages, version, and platform.

I offer two reasons for marking this method as deprecated:

  1. It accepts a distinct_count parameter but lacks has_distinct_count, making it impossible to represent missing distinct counts, which could lead to misuse.
  2. When I try to add nan_count, I found that it lacks a ColumnDescriptor parameter, making it impossible to obtain the logical type and determine the value of has_nan_count based on Parquet's logical type (FLOAT16).

Component(s)

C++, Parquet

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions