Skip to content

[Dev] Fix SC2035 shellcheck errors in the cpp/src/arrow/vendored directory. #51297

Description

@hiroyuki-sato

Describe the enhancement requested

This is the sub issue #44748.

  • Use ./*glob* or -- *glob* so names with dashes won't become options.
In cpp/src/arrow/vendored/fast_float/update.sh line 40:
sed -i.bak -E -e "s/v[0-9.]+/v${version}/g" *.h
                                            ^-- SC2035 (info): Use ./*glob* or -- *glob* so names with dashes won't become options.


In cpp/src/arrow/vendored/fast_float/update.sh line 44:
    *.h
    ^-- SC2035 (info): Use ./*glob* or -- *glob* so names with dashes won't become options.


In cpp/src/arrow/vendored/fast_float/update.sh line 45:
rm *.bak
   ^-- SC2035 (info): Use ./*glob* or -- *glob* so names with dashes won't become options.


In cpp/src/arrow/vendored/datetime/update.sh line 48:
    *.{cpp,h,mm}
    ^-- SC2035 (info): Use ./*glob* or -- *glob* so names with dashes won't become options.


In cpp/src/arrow/vendored/datetime/update.sh line 51:
    *.h
    ^-- SC2035 (info): Use ./*glob* or -- *glob* so names with dashes won't become options.


In cpp/src/arrow/vendored/datetime/update.sh line 55:
rm *.bak
   ^-- SC2035 (info): Use ./*glob* or -- *glob* so names with dashes won't become options.


In cpp/src/arrow/vendored/double-conversion/update.sh line 38:
rm *.cc *.h
   ^-- SC2035 (info): Use ./*glob* or -- *glob* so names with dashes won't become options.
        ^-- SC2035 (info): Use ./*glob* or -- *glob* so names with dashes won't become options.


In cpp/src/arrow/vendored/double-conversion/update.sh line 43:
sed -i.bak -E -e "s/v[0-9.]+/v${version}/g" *.md
                                            ^-- SC2035 (info): Use ./*glob* or -- *glob* so names with dashes won't become options.


In cpp/src/arrow/vendored/double-conversion/update.sh line 49:
    *.{h,cc}
    ^-- SC2035 (info): Use ./*glob* or -- *glob* so names with dashes won't become options.


In cpp/src/arrow/vendored/double-conversion/update.sh line 50:
rm *.bak
   ^-- SC2035 (info): Use ./*glob* or -- *glob* so names with dashes won't become options.

For more information:
  https://www.shellcheck.net/wiki/SC2035 -- Use ./*glob* or -- *glob* so name...

Component(s)

Developer Tools

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions