Conversation
github-actions
Bot
added
Component: Parquet
Component: C++
awaiting review
Contributor
|
The change looks good. Can you fill in the description and remove the boiler plate? |
Author
|
lriggs
approved these changes
Apr 29, 2026
github-actions
Bot
added
awaiting committer review
pitrou
requested changes
May 13, 2026
Comment on lines
+180
to
+182
| for (auto& it : source.key_value_metadata) { | ||
| keys.push_back(std::move(it.key)); | ||
| values.push_back(std::move(it.value)); |
Member
There was a problem hiding this comment.
source is semantically constant (it's marked const) so we should not move any values from it like this.
Signed-off-by: Jason <libevent@yeah.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
avoid unnecessary copies
What changes are included in this PR?
use std::move to avoid unnecessary copies
Are these changes tested?
yes
Are there any user-facing changes?
no