GH-49753: [C++][Gandiva] Fix overflow in string functions.#49813
Open
abtom87 wants to merge 1 commit intoapache:mainfrom
Open
GH-49753: [C++][Gandiva] Fix overflow in string functions.#49813abtom87 wants to merge 1 commit intoapache:mainfrom
abtom87 wants to merge 1 commit intoapache:mainfrom
Conversation
Fixed overflows and added unit-tests.
github-actions
bot
added
Component: C++
Component: Gandiva
awaiting review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Fix the overflow in functions where strings are used
What changes are included in this PR?
FIxes overflow and handles negative lengths
Are these changes tested?
YES
Are there any user-facing changes?
YES
This PR includes breaking changes to public APIs. (If there are any breaking changes to public APIs, please explain which changes are breaking. If not, you can remove this.)
This PR contains a "Critical Fix". (If the changes fix either (a) a security vulnerability, (b) a bug that caused incorrect or invalid data to be produced, or (c) a bug that causes a crash (even when the API contract is upheld), please provide explanation. If not, you can remove this.)