GH-49974: [C++][CMake] Add missing result variable initialization for validate_apple_libtool() - #49975
Conversation
`find_package()`'s `VALIDATOR`'s result variable must be initialized to `TRUE` by caller.
|
|
github-actions
Bot
added
Component: C++
awaiting committer review
There was a problem hiding this comment.
Pull request overview
This PR fixes a macOS CMake configuration bug where explicitly setting -DCMAKE_LIBTOOL=... could fail validation because the VALIDATOR result variable wasn’t initialized before calling validate_apple_libtool().
Changes:
- Initialize
is_apple_libtooltoTRUEbefore invokingvalidate_apple_libtool()whenCMAKE_LIBTOOLis explicitly provided.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
+1 Tested: #49974 (comment) |
|
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 6d6f246. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 27 possible false positives for unstable benchmarks that are known to sometimes produce them. |
…on for `validate_apple_libtool()` (apache#49975) ### Rationale for this change `find_package()`'s `VALIDATOR`'s result variable must be initialized to `TRUE` by caller. We reuse the `VALIDATOR` (`validate_apple_libtool()`) when we specify `CMAKE_LIBTOOL` explicitly. But we didn't initialize the result variable to `TRUE`. ### What changes are included in this PR? Initialize `is_apple_libtool` explicitly. ### Are these changes tested? Yes. ### Are there any user-facing changes? Yes. * GitHub Issue: apache#49974 Authored-by: Sutou Kouhei <kou@clear-code.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Rationale for this change
find_package()'sVALIDATOR's result variable must be initialized toTRUEby caller.We reuse the
VALIDATOR(validate_apple_libtool()) when we specifyCMAKE_LIBTOOLexplicitly. But we didn't initialize the result variable toTRUE.What changes are included in this PR?
Initialize
is_apple_libtoolexplicitly.Are these changes tested?
Yes.
Are there any user-facing changes?
Yes.