GH-50298: [CI][R] Update ubuntu-clang CI job to use clang 22 to match CRAN - #50299
Conversation
|
|
|
|
|
Once we're happy with this, we should file an issue on rhub |
There was a problem hiding this comment.
Pull request overview
Updates the R “as-CRAN” CI workflow to better match CRAN’s current debian-clang toolchain by enabling an optional clang upgrade path for the rhub/ubuntu-clang image.
Changes:
- Adds a per-matrix flag (
r_update_clang) for theubuntu-clangjob to trigger a clang upgrade. - Wires
R_UPDATE_CLANGthrough the GitHub workflow → Docker Compose build args →linux-r.dockerfile→r_docker_configure.sh. - Adds an
apt.llvm.org-based installation step intended to install clang 22 inside the R image.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| dev/tasks/r/github.linux.cran.yml | Adds matrix flag and env var to enable clang updates for ubuntu-clang. |
| compose.yaml | Passes R_UPDATE_CLANG into the r image build args. |
| ci/scripts/r_docker_configure.sh | Implements the clang 22 installation logic when R_UPDATE_CLANG=true. |
| ci/docker/linux-r.dockerfile | Introduces r_update_clang build arg and propagates it to R_UPDATE_CLANG. |
|
@github-actions crossbow submit test-r-linux-as-cran |
|
Revision: f846f90 Submitted crossbow builds: ursacomputing/crossbow @ actions-9491b6cbd6
|
f846f90 to
cb36963
Compare
|
@github-actions crossbow submit test-r-linux-as-cran |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.
Suppressed comments (2)
ci/scripts/r_docker_configure.sh:97
- The LLVM APT repo is hardcoded to
jammyand the GPG key is added to/etc/apt/trusted.gpg.d, which makes this job brittle (if the base image isn’t Ubuntu 22.04) and grants the key global trust. The repo already uses a more robust pattern elsewhere (derive the distro codename and usesigned-by=).
apt-get update -y --allow-releaseinfo-change
apt-get install -y gnupg
curl -fsSL https://apt.llvm.org/llvm-snapshot.gpg.key | gpg --dearmor -o /etc/apt/trusted.gpg.d/llvm.gpg
echo "deb https://apt.llvm.org/jammy/ llvm-toolchain-jammy-22 main" > /etc/apt/sources.list.d/llvm22.list
apt-get update -y --allow-releaseinfo-change
compose.yaml:1688
- Adding
r_update_clang: ${R_UPDATE_CLANG}introduces a new required env var fordocker compose buildand will emit a warning / pass an empty build arg when unset. Using a default keeps local/CI runs quieter and ensuresARG r_update_clang=falseremains effective.
r_update_clang: ${R_UPDATE_CLANG}
|
Revision: f80c846 Submitted crossbow builds: ursacomputing/crossbow @ actions-1183ed957e
|
|
@github-actions crossbow submit test-r-linux-as-cran |
|
Revision: f80c846 Submitted crossbow builds: ursacomputing/crossbow @ actions-65528c02b5
|
jonkeane
left a comment
jonkeane
left a comment
There was a problem hiding this comment.
Is this effectively the same as this line: https://github.com/apache/arrow/pull/50299/changes#diff-dbaf9a10b8e9f991e04ac5206183c2b4dfa9ca0e7977c7c14894952761fb7cd1R36 ?
| # The rhub/ubuntu-clang image ships clang-15 but CRAN's debian-clang now uses | ||
| # clang 22. Install clang-22 from LLVM's apt repos to match. |
There was a problem hiding this comment.
Do we need to upstream this to rhub too? Could we link the issue / PR doing that?
github-actions
Bot
added
awaiting changes
Both rhub images are Ubuntu-based, but the |
Rationale for this change
CI clang version outdated, false positive failures against CRAN
What changes are included in this PR?
Update clang manually
Are these changes tested?
Will run CI
Are there any user-facing changes?
No