Skip to content

GH-50654: [C++] Support simdjson without exceptions - #50672

Open
Reranko05 wants to merge 1 commit into
apache:mainfrom
Reranko05:gh-50654-excep-off
Open

GH-50654: [C++] Support simdjson without exceptions#50672
Reranko05 wants to merge 1 commit into
apache:mainfrom
Reranko05:gh-50654-excep-off

Conversation

@Reranko05

@Reranko05 Reranko05 commented Jul 28, 2026 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Contributor

Rationale for this change

This change enables building Arrow with SIMDJSON_EXCEPTIONS=0 by updating the JSON object parser to use simdjson's non-throwing API.

What changes are included?

  • Enable SIMDJSON_EXCEPTIONS=0 for the bundled simdjson dependency.
  • Replace uses of simdjson_result::value() in ObjectParser with the non-throwing get() API.
  • Preserve existing error handling by returning Arrow Status values on simdjson errors.

Are these changes tested?

Yes.

Fixes: #50654

@Reranko05
Reranko05 requested a review from pitrou as a code owner July 28, 2026 03:38
Copilot AI review requested due to automatic review settings July 28, 2026 03:38
Copilot AI reviewed Jul 28, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@Reranko05

Reranko05 commented Jul 28, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

@kou @rok Could you review this when you have time? Thanks!

kou
kou reviewed Jul 28, 2026
View reviewed changes
Comment thread cpp/src/arrow/json/object_parser.cc Outdated
@github-actions github-actions Bot added awaiting changes Awaiting changes and removed awaiting review Awaiting review labels Jul 28, 2026
Copilot AI review requested due to automatic review settings July 28, 2026 06:40
@Reranko05
Reranko05 force-pushed the gh-50654-excep-off branch from f94fe05 to fde573a Compare July 28, 2026 06:40
Copilot AI reviewed Jul 28, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@github-actions github-actions Bot added awaiting change review Awaiting change review awaiting changes Awaiting changes and removed awaiting changes Awaiting changes awaiting change review Awaiting change review labels Jul 28, 2026
@Reranko05
Reranko05 requested a review from kou July 28, 2026 07:15
kou
kou reviewed Jul 28, 2026
View reviewed changes
Comment thread cpp/src/arrow/json/object_parser.cc Outdated
kou
kou approved these changes Jul 28, 2026
View reviewed changes

@kou kou left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Copilot AI review requested due to automatic review settings July 28, 2026 08:41
@Reranko05
Reranko05 force-pushed the gh-50654-excep-off branch from fde573a to 92ae650 Compare July 28, 2026 08:41
Copilot AI reviewed Jul 28, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@github-actions github-actions Bot added awaiting change review Awaiting change review awaiting merge Awaiting merge and removed awaiting changes Awaiting changes awaiting change review Awaiting change review labels Jul 28, 2026
@Reranko05
Reranko05 requested a review from kou July 28, 2026 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rok rok rok left review comments
Copilot code review Copilot Copilot left review comments
@pitrou pitrou Awaiting requested review from pitrou pitrou is a code owner
@kou kou Awaiting requested review from kou

Assignees

No one assigned

Labels

awaiting merge Awaiting merge Component: C++

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[C++] Turn off exceptions in simdjson

4 participants

@Reranko05 @kou @rok