Skip to content

GH-50680: [C++][Dev] Extend type IDs in gdb_arrow.py - #50683

Merged
pitrou merged 1 commit into
apache:mainfrom
fenfeng9:gh-50680-update-gdb-type-ids
Jul 28, 2026
Merged

GH-50680: [C++][Dev] Extend type IDs in gdb_arrow.py#50683
pitrou merged 1 commit into
apache:mainfrom
fenfeng9:gh-50680-update-gdb-type-ids

Conversation

@fenfeng9

@fenfeng9 fenfeng9 commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

Rationale for this change

gdb_arrow.py mirrors the C++ arrow::Type::type enum by position, but it is missing several newer type IDs.

The upcoming pretty-printer sub-issues(#50656) share this dependency.

What changes are included in this PR?

Adds the missing RunEndEncoded, BinaryView, ListView, and Decimal32/64 type IDs in the same order as the C++ enum.

Individual pretty-printer support will be implemented separately.

Are these changes tested?

Are there any user-facing changes?

No.

@fenfeng9

Copy link
Copy Markdown
Contributor Author

@kou Could you please review this?

This adds the shared type IDs needed by #50657#50660, avoiding duplicate changes and conflicts in the follow-up PRs.

@github-actions github-actions Bot added the awaiting review Awaiting review label Jul 28, 2026
@fenfeng9

Copy link
Copy Markdown
Contributor Author

The four macOS failures appear unrelated to this PR.

@fenfeng9

Copy link
Copy Markdown
Contributor Author

@pitrou Could you please review this?

@pitrou pitrou left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, thank you @fenfeng9

@pitrou
pitrou merged commit 2ae036f into apache:main Jul 28, 2026
52 of 56 checks passed
@pitrou pitrou removed the awaiting review Awaiting review label Jul 28, 2026
@github-actions github-actions Bot added the awaiting committer review Awaiting committer review label Jul 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants