Skip to content

GH-50728: [C++] Remove call_traits::argument_count in favor of type_traits - #50729

Merged
pitrou merged 2 commits into
apache:mainfrom
taepper:remove-argument-count
Aug 26, 2026
Merged

pitrou merged 2 commits into
apache:mainfrom
taepper:remove-argument-count

Conversation

@taepper

@taepper taepper commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

Rationale for this change

As part of #50250 we slowly want to remove the custom metaprogramming helpers

What changes are included in this PR?

This removes call_traits::argument_count in favor of type_traits.

We could also remove ContinueFuture::ForSignature because std::invoke_result already checks the signature.

Are these changes tested?

Yes.

Are there any user-facing changes?

No

@taepper
taepper requested a review from pitrou as a code owner July 30, 2026 05:55
@github-actions

Copy link
Copy Markdown

⚠️ GitHub issue #50728 has been automatically assigned in GitHub to PR creator.

@taepper taepper changed the title GH-50728: [C++] remove call_traits::argument_count in favor of type_traits GH-50728: [C++] Remove call_traits::argument_count in favor of type_traits Jul 30, 2026
@taepper
taepper force-pushed the remove-argument-count branch from 9058c00 to 6f80a34 Compare July 31, 2026 06:24
@taepper

taepper commented Aug 25, 2026

Copy link
Copy Markdown
Contributor Author

bump @HuaHuaY @kou @pitrou

@pitrou

pitrou commented Aug 26, 2026

Copy link
Copy Markdown
Member

@github-actions crossbow submit -g cpp

@github-actions github-actions Bot added awaiting committer review Awaiting committer review and removed awaiting review Awaiting review labels Aug 26, 2026
@github-actions

Copy link
Copy Markdown

Revision: 6c95106

Submitted crossbow builds: ursacomputing/crossbow @ actions-1da1365e24

Task Status
example-cpp-minimal-build-static GitHub Actions
example-cpp-minimal-build-static-system-dependency GitHub Actions
example-cpp-tutorial GitHub Actions
test-build-cpp-fuzz GitHub Actions
test-conda-cpp GitHub Actions
test-conda-cpp-valgrind GitHub Actions
test-debian-13-cpp-amd64 GitHub Actions
test-debian-13-cpp-i386 GitHub Actions
test-debian-experimental-cpp-gcc-15 GitHub Actions
test-fedora-42-cpp GitHub Actions
test-ubuntu-22.04-cpp GitHub Actions
test-ubuntu-22.04-cpp-bundled GitHub Actions
test-ubuntu-22.04-cpp-emscripten GitHub Actions
test-ubuntu-22.04-cpp-no-threading GitHub Actions
test-ubuntu-24.04-cpp GitHub Actions
test-ubuntu-24.04-cpp-bundled-offline GitHub Actions
test-ubuntu-24.04-cpp-gcc-13-bundled GitHub Actions
test-ubuntu-24.04-cpp-gcc-14 GitHub Actions
test-ubuntu-24.04-cpp-minimal-with-formats GitHub Actions
test-ubuntu-24.04-cpp-thread-sanitizer GitHub Actions

@pitrou

pitrou commented Aug 26, 2026

Copy link
Copy Markdown
Member

Thanks a lot @taepper . The CI failures are unrelated, I'll merge.

@pitrou
pitrou merged commit 4c9c373 into apache:main Aug 26, 2026
60 checks passed
@pitrou pitrou removed the awaiting committer review Awaiting committer review label Aug 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants