GH-50778: [C++][Parquet] Fix chunked level histogram accumulation - #50780
Merged
Merged
Conversation
|
|
wgtmac
approved these changes
Aug 3, 2026
github-actions
Bot
added
awaiting committer review
Contributor
Author
|
@wgtmac Can we merge this if no more concerns? Thanks! |
pitrou
approved these changes
Aug 31, 2026
pitrou
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
UpdateLevelHistogramincorrectly accumulated from the beginning of the input on every iteration of itsmax_level == 1fast path. Inputs spanning multiple chunks therefore counted the first chunk repeatedly.Fix #50778.
What changes are included in this PR?
itrather thanlevels.begin().Are these changes tested?
Yes, passing the new UT and existing UT.
Are there any user-facing changes?
No.