GH-51100: [C++][Format] Deprecate IPC tensor/sparse tensor messages - #51102
Conversation
|
|
|
Let's keep this PR draft until final consensus is reached on the ML. |
5802278 to
d787c88
Compare
|
@pitrou I'm very much on board with the sparse tensors. I so wonder about tensors, are we sure this is not being used? I'm ok to add a deprecation and wait for a release to see if we hear back. But my expectation is there would be some users out there. |
Hopefully the deprecation will have them chime in? But my attempt at code-searching this on GH did not lead to many recent relevant results. |
Agreed. I'll take a look myself and report back. |
d787c88 to
efcd686
Compare
|
@wgtmac @CurtHagenlocher @lidavidm Would you like to take a look? |
|
@github-actions crossbow submit preview-docs |
|
Should this also cover pyarrow.ipc.read_tensor, |
|
We can tackle Python in a separate PR, IMHO. |
|
(I'm not sure what's with the "Release and Merge Script" CI jobs? @kou ) |
|
Revision: a15a298 Submitted crossbow builds: ursacomputing/crossbow @ actions-19c98b222c
|
|
Rendered docs at https://s3.amazonaws.com/arrow-data/pr_docs/51102/format/Other.html |
|
@github-actions crossbow submit preview-docs |
|
Revision: 9037076 Submitted crossbow builds: ursacomputing/crossbow @ actions-9ae2c160cd
|
kou
left a comment
There was a problem hiding this comment.
+1
The "Source Release and Merge Script" failure is a timing problem. It should be fixed by re-run. (I've re-run the job.)
Rationale for this change
Deprecate Tensor and SparseTensor messages in the IPC specification.
Deprecate C++ APIs for reading and writing Tensor and SparseTensor IPC messages.
Deprecating IPC support for Tensor and SparseTensor was decided in https://lists.apache.org/thread/w7nvhjyks3p3smw5kq4ylv0nkwxq2s2q
Are these changes tested?
By existing CI tests.
Are there any user-facing changes?
No.