Skip to content

GH-51044: [Python] Reject read-only readinto destinations #51126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
raulcd merged 2 commits into from
Sep 9, 2026
Merged

GH-51044: [Python] Reject read-only readinto destinations #51126

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f0684d2
GH-51044: Reject read-only readinto destinations
carrerasdarren-cell Sep 1, 2026
6fbd4a0
GH-51044: [Python] Group readinto buffer test with buffer tests
carrerasdarren-cell Sep 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions python/pyarrow/io.pxi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -548,6 +548,8 @@ cdef class NativeFile(_Weakrefable):
handle = self.get_input_stream()

py_buf = py_buffer(b)
if not py_buf.buffer.get().is_mutable():
raise TypeError("readinto() argument must be a writable buffer")
buf_len = py_buf.size
buf = py_buf.buffer.get().mutable_data()

Expand Down
7 changes: 7 additions & 0 deletions python/pyarrow/tests/test_io.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1024,6 +1024,13 @@ def test_nativefile_write_memoryview():
assert buf.to_pybytes() == data * 3


@pytest.mark.parametrize("dst_buf", [b"a", memoryview(b"a")])
def test_native_file_readinto_rejects_readonly_buffer(dst_buf):
with pa.BufferReader(b"x") as f:
with pytest.raises(TypeError, match="writable buffer"):
f.readinto(dst_buf)


# ----------------------------------------------------------------------
# Mock output stream

Expand Down