Skip to content

GH-51232: [CI] Remove the "take" comment bot for self-assigning issues - #51233

Merged
thisisnic merged 3 commits into
apache:mainfrom
thisisnic:GH-51232-fix-take
Sep 17, 2026
Merged

thisisnic merged 3 commits into
apache:mainfrom
thisisnic:GH-51232-fix-take

Conversation

@thisisnic

@thisisnic thisisnic commented Sep 8, 2026

Copy link
Copy Markdown
Member

Rationale for this change

Anyone could assign themselves an issue by commenting "take", including issues already assigned to someone else. Assignment should be handled by committers and collaborators instead.

What changes are included in this PR?

Removes the issue_assign job from the comment bot workflow and updates the contributor docs to say that a committer or collaborator will assign issues on request.

Are these changes tested?

No. Docs were checked with sphinx-lint via pre-commit.

Are there any user-facing changes?

No. Contributors can no longer self-assign issues by commenting "take".

Copilot AI lite review requested due to automatic review settings September 8, 2026 10:19
@thisisnic
thisisnic requested a review from raulcd as a code owner September 8, 2026 10:19

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The workflow still runs on PR comments (issue_comment applies to PRs too), so take can unintentionally assign pull requests unless the job is additionally gated to issues-only.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

Updates Arrow’s GitHub comment bot (“take”) behavior and contributor docs so that self-assignment only occurs when an issue is currently unassigned, preventing accidental reassignment of already-owned issues.

Changes:

  • Restrict the comment_bot.yml “Assign issue” job to run only when the issue has no assignee.
  • Update developer documentation to clarify that take only works on unassigned issues.
File summaries
File Description
docs/source/developers/bug_reports.rst Clarifies that take only self-assigns unassigned issues.
CONTRIBUTING.md Updates contributor guidance to match the new take behavior.
.github/workflows/comment_bot.yml Adds an “unassigned only” guard to the take-based assignment job.
Review details
  • Files reviewed: 3/3 changed files
  • Comments generated: 1
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread .github/workflows/comment_bot.yml Outdated
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings September 8, 2026 10:27

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The workflow condition change directly addresses the reported issue and the accompanying documentation updates are consistent with the new behavior.

Review details
  • Files reviewed: 3/3 changed files
  • Comments generated: 0 new
  • Review effort level: Lite

Copilot AI review requested due to automatic review settings September 17, 2026 17:22
@thisisnic thisisnic changed the title GH-51232: [CI] Update comment bot to prevent people being assigned things via "take" unless unassigned GH-51232: [CI] Remove the "take" comment bot for self-assigning issues Sep 17, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

Reconcile the implementation and PR description, and update the inconsistent assignment guidance.

Review details

Suppressed comments (2)

docs/source/developers/guide/tutorials/python_tutorial.rst:95

  • This new assignment policy leaves the R tutorial inconsistent: docs/source/developers/guide/tutorials/r_tutorial.rst:92 still tells contributors an issue is “assigned to yourself”, which is no longer possible for non-collaborators after removing take. Please update that tutorial in the same PR.
We should make sure to let others know we are working on the issue.
You can do that by adding a comment to the issue created saying you
would like to work on it, and a committer or collaborator will assign
it to you.

docs/source/developers/guide/tutorials/python_tutorial.rst:95

  • The workflow change removes the take command entirely, while the PR description says take should still assign an unassigned issue. This also changes the contributor-facing behavior documented here; please reconcile the implementation and PR description (the linked issue explicitly requests removing the command).
We should make sure to let others know we are working on the issue.
You can do that by adding a comment to the issue created saying you
would like to work on it, and a committer or collaborator will assign
it to you.
  • Files reviewed: 6/6 changed files
  • Comments generated: 0 new
  • Review effort level: Lite

@rok rok left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@github-actions github-actions Bot added awaiting merge Awaiting merge and removed awaiting committer review Awaiting committer review labels Sep 17, 2026
@thisisnic
thisisnic merged commit 4375193 into apache:main Sep 17, 2026
34 checks passed
@thisisnic thisisnic removed the awaiting merge Awaiting merge label Sep 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants