GH-51278: [C++] Fix build error in acero tests with gcc 16 - #51279
Merged
Conversation
pitrou
approved these changes
Sep 10, 2026
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The change directly addresses the reported GCC 16 warning by eliminating an unsafe member call during construction, with no apparent behavioral impact beyond that fix.
Pull request overview
Fixes a GCC 16 -Wmaybe-uninitialized warning/error in Acero test utilities by removing a call to a non-static member function during base-class construction of DummyNode.
Changes:
- Make
DummyNode::dummy_schema()astaticfunction so it can be safely used in theExecNodebase-class initializer.
File summaries
| File | Description |
|---|---|
| cpp/src/arrow/acero/test_util_internal.cc | Makes dummy_schema() static to avoid calling an instance method before DummyNode is fully constructed. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
github-actions
Bot
added
awaiting committer review
zanmato1984
approved these changes
Sep 10, 2026
zanmato1984
left a comment
zanmato1984
left a comment
Contributor
There was a problem hiding this comment.
+1
Thanks for fixing this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Fixes a "may be used uninitialized" build error encountered with gcc 16.2.1 (see #51278)
What changes are included in this PR?
Change a test method to static.
Are these changes tested?
Yes, I've built and run the acero tests.
Are there any user-facing changes?
No