Skip to content

GH-51300: Fix deprecation warnings for null_placement #51307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
taepper wants to merge 2 commits into
base: main
Choose a base branch
from
+12 −14
Open

GH-51300: Fix deprecation warnings for null_placement #51307

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
047a597
silence deprecation warnings
taepper Sep 11, 2026
fb2250a
migrate tests to non-deprecated api instead
taepper Sep 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 12 additions & 14 deletions python/pyarrow/tests/test_compute.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,10 +172,9 @@ def test_option_class_equality(request):
pc.PivotWiderOptions(["height"], unexpected_key_behavior="raise"),
pc.QuantileOptions(),
pc.RandomOptions(),
pc.RankOptions(sort_keys="ascending",
null_placement="at_end", tiebreaker="max"),
pc.RankQuantileOptions(sort_keys="ascending",
null_placement="at_end"),
pc.RankOptions(sort_keys=[("", "ascending", "at_end")],
tiebreaker="max"),
pc.RankQuantileOptions(sort_keys=[("", "ascending", "at_end")]),
pc.ReplaceSliceOptions(0, 1, "a"),
pc.ReplaceSubstringOptions("a", "b"),
pc.RoundOptions(2, "towards_infinity"),
Expand Down Expand Up @@ -3882,8 +3881,7 @@ def test_random():
)
def test_rank_options_tiebreaker(tiebreaker, expected_values):
arr = pa.array([1.2, 0.0, 5.3, None, 5.3, None, 0.0])
rank_options = pc.RankOptions(sort_keys="ascending",
null_placement="at_end",
rank_options = pc.RankOptions(sort_keys=[("", "ascending", "at_end")],
tiebreaker=tiebreaker)
result = pc.rank(arr, options=rank_options)
expected = pa.array(expected_values, type=pa.uint64())
Expand All @@ -3908,7 +3906,7 @@ def test_rank_options():
)
assert result.equals(expected)

result = pc.rank(arr, null_placement="at_start")
result = pc.rank(arr, sort_keys=[("", "ascending", "at_start")])
expected_at_start = pa.array([5, 3, 6, 1, 7, 2, 4], type=pa.uint64())
assert result.equals(expected_at_start)

Expand All @@ -3918,8 +3916,7 @@ def test_rank_options():

with pytest.raises(ValueError,
match=r'"NonExisting" is not a valid tiebreaker'):
pc.RankOptions(sort_keys="descending",
null_placement="at_end",
pc.RankOptions(sort_keys=[("", "descending", "at_end")],
tiebreaker="NonExisting")


Expand All @@ -3941,7 +3938,7 @@ def test_rank_quantile_options():
)
assert result.equals(expected)

result = pc.rank_quantile(arr, null_placement="at_start")
result = pc.rank_quantile(arr, sort_keys=[("", "ascending", "at_start")])
expected_at_start = pa.array([0.3, 0.7, 0.3, 0.9, 0.3], type=pa.float64())
assert result.equals(expected_at_start)

Expand All @@ -3961,19 +3958,20 @@ def test_rank_normal_options():
-0.5244005127080409, 0.5244005127080407])
result = pc.rank_normal(arr)
assert result.to_pylist() == expected
result = pc.rank_normal(arr, null_placement="at_end", sort_keys="ascending")
result = pc.rank_normal(arr, sort_keys=[("", "ascending", "at_end")])
assert result.to_pylist() == expected
result = pc.rank_normal(arr, options=pc.RankQuantileOptions())
assert result.to_pylist() == expected

expected = pytest.approx(
[-0.5244005127080409, 1.2815515655446004, -0.5244005127080409,
0.5244005127080407, -0.5244005127080409])
result = pc.rank_normal(arr, null_placement="at_start", sort_keys="descending")
result = pc.rank_normal(arr, sort_keys=[("", "descending", "at_start")])
assert result.to_pylist() == expected
result = pc.rank_normal(arr,
options=pc.RankQuantileOptions(null_placement="at_start",
sort_keys="descending"))
options=pc.RankQuantileOptions(
sort_keys=[("", "descending", "at_start")])
)
assert result.to_pylist() == expected


Expand Down