Skip to content

MINOR: [Dev] Fix the auto-posted title-check comment - #51358

Closed
simpleqt wants to merge 1 commit into
apache:mainfrom
simpleqt:sq916/title-check-comment
Closed

simpleqt wants to merge 1 commit into
apache:mainfrom
simpleqt:sq916/title-check-comment

Conversation

@simpleqt

Copy link
Copy Markdown

The comment posted verbatim by .github/workflows/dev_pr/title_check.js when a PR title fails the check has two small defects:

  • the link targets CONTRIBUTING.md#Minor-Fixes, but the heading's slug is #minor-fixes (GitHub anchors are lowercase), so it lands at the top of the page instead of the Minor Fixes section;
  • the conditional ends with a period ("If this is not a minor PR. Could you open...") — joined with a comma.

Was AI used for this PR?

  • Yes — AI was used to author this change; a human reviewed and verified the anchor slug and the posted-comment path (title_check.js:31) before submitting.

The comment posted by the dev_pr title check pointed at
CONTRIBUTING.md#Minor-Fixes, but the heading slug is lowercase
(#minor-fixes), so the anchor landed at the top of the page. The
conditional clause also ended with a period, producing a sentence
fragment; join it with a comma.

Signed-off-by: simpleqt <89645338+simpleqt@users.noreply.github.com>
Copilot AI lite review requested due to automatic review settings September 16, 2026 16:33

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@Reranko05 Reranko05 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked the existing #Minor-Fixes link in title_check.md, and it already navigates to the correct Minor Fixes section on the CONTRIBUTING.md page. Could you clarify if there's a specific case where the current anchor doesn't work?

@kou

kou commented Sep 17, 2026

Copy link
Copy Markdown
Member

This is an AI-slop.

@kou kou closed this Sep 17, 2026
@raulcd

raulcd commented Sep 17, 2026

Copy link
Copy Markdown
Member

This AI slop bot has also created a couple other MINOR PRs which are PRs that catch real issues but I am unsure we want to merge them. As soon as we merge a PR the user PRs will trigger CI and to be fair I am unsure we want to do that for this kind of users. See:
https://github.com/apache/arrow/pulls?q=is%3Apr+state%3Aopen+author%3Asimpleqt

@kou @pitrou thoughts?

@pitrou

pitrou commented Sep 17, 2026

Copy link
Copy Markdown
Member

@raulcd Perhaps open our own PRs for these issues? The main contribution was in finding them, probably, since the fixes are trivial.

@raulcd

raulcd commented Sep 17, 2026

Copy link
Copy Markdown
Member

@pitrou sure, it was more about what approach to take on those. I am fine not merging them and pushing them ourselves.

pitrou pushed a commit that referenced this pull request Sep 17, 2026
### Rationale for this change

Fix three minor issues as discussed in #51358 (comment)

### What changes are included in this PR?

- Fix the punctuation in title-check comment.
- Remove an extra parenthesis from the `pyrunfile` link in the MATLAB documentation.
- Fix the `buffers` parameter name in the `buffers_to_array` documentation.

### Are these changes tested?

These are minor documentation fixes.

### Are there any user-facing changes?

Yes. 

### Was AI used for this PR?

In accordance to the [AI generation guidelines](https://arrow.apache.org/docs/dev/developers/overview.html#ai-generated-code), please disclose below whether and how AI was used in this PR.

**PR code and description written by:**

- [X] Human
- [ ] AI

**Reviewed before submission by:**

- [X] Human
- [ ] AI
- [ ] Not reviewed

Authored-by: Aaditya Srinivasan <aadityasri03@gmail.com>
Signed-off-by: Antoine Pitrou <antoine@python.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants