Skip to content

GH-45723 unsafeappend to FixedSizeListBuilder #51382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dkp116 wants to merge 4 commits into
base: main
Choose a base branch
from
+42 −1
Open

GH-45723 unsafeappend to FixedSizeListBuilder #51382

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f73a8fa
GH-45723: [C++] Add UnsafeAppend to FixedSizeListBuffer
dkp116 Sep 17, 2026
4e9f473
GH-45723: [C++] Add test for Append
dkp116 Sep 17, 2026
8f9fe74
GH-45723: [C++] Add docstring to UnsafeAppend and inline implementation
dkp116 Sep 21, 2026
9eb6de3
GH-45723: [C++] Add test for UnsafeAppend for FixedSizeBuilder
dkp116 Sep 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 34 additions & 0 deletions cpp/src/arrow/array/array_list_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1600,6 +1600,16 @@ class TestFixedSizeListArray : public ::testing::Test {
std::shared_ptr<FixedSizeListArray> result_;
};

// TEST_F(TestFixedSizeListArray, TestUnsafeAppend) {
// ASSERT_OK(builder_->Reserve(2));
// builder_->UnsafeAppend();
// builder_->UnsafeAppend();

// Done();

// ASSERT_EQ(result_->length(), 2);
// }

TEST_F(TestFixedSizeListArray, Equality) {
Int32Builder* vb = checked_cast<Int32Builder*>(builder_->value_builder());

Expand Down Expand Up @@ -1722,6 +1732,30 @@ TEST_F(TestFixedSizeListArray, TestBasics) {
ValidateBasicFixedSizeListArray(result_.get(), values, is_valid);
}

TEST_F(TestFixedSizeListArray, TestBasicsWithUnsafeAppend) {
std::vector<int32_t> values = {0, 1, 2, 3, 4, 5};
std::vector<uint8_t> is_valid = {1, 0, 1};

Int32Builder* vb = checked_cast<Int32Builder*>(builder_->value_builder());

int pos = 0;
ASSERT_OK(builder_->Reserve(values.size() / list_size()));
for (size_t i = 0; i < values.size() / list_size(); ++i) {
if (is_valid[i] == 0) {
ASSERT_OK(builder_->AppendNull());
pos += list_size();
continue;
}
builder_->UnsafeAppend();
for (int j = 0; j < list_size(); ++j) {
ASSERT_OK(vb->Append(values[pos++]));
}
}

Done();
ValidateBasicFixedSizeListArray(result_.get(), values, is_valid);
}

TEST_F(TestFixedSizeListArray, BulkAppend) {
std::vector<int32_t> values = {0, 1, 2, 3, 4, 5};
std::vector<uint8_t> is_valid = {1, 0, 1};
Expand Down
2 changes: 1 addition & 1 deletion cpp/src/arrow/array/builder_nested.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,7 +200,7 @@ void FixedSizeListBuilder::Reset() {

Status FixedSizeListBuilder::Append() {
RETURN_NOT_OK(Reserve(1));
UnsafeAppendToBitmap(true);
UnsafeAppend();
return Status::OK();
}

Expand Down
7 changes: 7 additions & 0 deletions cpp/src/arrow/array/builder_nested.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -725,6 +725,13 @@ class ARROW_EXPORT FixedSizeListBuilder : public ArrayBuilder {
return std::numeric_limits<FixedSizeListType::offset_type>::max() - 1;
}

/// \brief UnsafeAppend a valid fixed length list.
///
/// This function affects only the validity bitmap; the child values must be appended
/// using the child array builder. The caller must ensure that sufficient capacity is
/// available.
void UnsafeAppend() { UnsafeAppendToBitmap(true); }

protected:
std::shared_ptr<Field> value_field_;
const int32_t list_size_;
Expand Down
Loading