Conversation
Map selected Parquet leaf columns back to their top-level Arrow fields before recording tracing attributes. Add OpenTelemetry coverage for flat, nested, reordered, full-schema, and direct reads.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Fixes #51370.
The
parquet::arrow::read_columnspan used a reader-vector position as a Parquet leaf-column index. This reported the wrong column attributes for reordered or subset reads and did not represent nested top-level fields correctly.What changes are included in this PR?
Are these changes tested?
Yes.
parquet-arrow-reader-writer-tracing-test: 5 tests passed.parquet-arrow-reader-writer-test: 823 tests passed and 9 configuration-dependent tests were skipped.Are there any user-facing changes?
OpenTelemetry spans now report the correct top-level Arrow field metadata. There are no public API changes.
Was AI used for this PR?
In accordance with the AI generation guidelines, AI was used to implement, test, rebase, and prepare this change. The proposed behavior was discussed on #51370 before submission.
PR code and description written by:
Reviewed before submission by: