GH-51456: [C++] Make ABI independent of ARROW_EXTRA_ERROR_CONTEXT

[pitrou]

What changes are included in this PR?

Allow applications compiled with ARROW_EXTRA_ERROR_CONTEXT enabled to link against libarrow compiled with ARROW_EXTRA_ERROR_CONTEXT disabled, and vice-versa.

Also improve unit tests slightly.

Are these changes tested?

The original issue was tested manually.

Are there any user-facing changes?

No.

Was AI used for this PR?

In accordance to the AI generation guidelines, please disclose below whether and how AI was used in this PR.

PR code and description written by:

• Human
• AI

Reviewed before submission by:

• Human
• AI
• Not reviewed

• GitHub Issue: [C++] ABI depends on ARROW_EXTRA_ERROR_CONTEXT #51456

[github-actions]

⚠️ GitHub issue #51456 has been automatically assigned in GitHub to PR creator.

[pitrou]

@HuaHuaY @taepper What do you think?

[taepper]

This reduces the usage of ARROW_EXTRA_ERROR_CONTEXT in the codebase to this single instance:

#ifdef ARROW_EXTRA_ERROR_CONTEXT

/// \brief Return with given status if condition is met.
#  define ARROW_RETURN_IF_(condition, status, expr)   \
    do {                                              \
      if (ARROW_PREDICT_FALSE(condition)) {           \
        ::arrow::Status _st = (status);               \
        _st.AddContextLine(__FILE__, __LINE__, expr); \
        return _st;                                   \
      }                                               \
    } while (0)

#else

#  define ARROW_RETURN_IF_(condition, status, _) \
    do {                                         \
      if (ARROW_PREDICT_FALSE(condition)) {      \
        return (status);                         \
      }                                          \
    } while (0)

#endif  // ARROW_EXTRA_ERROR_CONTEXT

Which is exactly what I would expect

[pitrou]

I've addressed all review comments and I'm going to merge this PR. Thank you @HuaHuaY @taepper !