Conversation
dkp116
requested review from
HuaHuaY,
jonkeane,
lidavidm,
pitrou,
thisisnic and
wgtmac
as code owners
September 22, 2026 14:26
Contributor
|
Did this change all usages of What is the rationale behind this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Upgrade to meet c++20 standards, looking at implementation of same_as on cppref this can be replace is_same_v
https://en.cppreference.com/cpp/concepts/same_as
What changes are included in this PR?
Replace std::is_same_v with std::same_as
Are these changes tested?
Ran testing library, no need to create new test case
Are there any user-facing changes?
No
Was AI used for this PR?
No
In accordance to the AI generation guidelines, please disclose below whether and how AI was used in this PR.
PR code and description written by:
Reviewed before submission by:
std::is_same_vwithstd::same_as#50720