ARTEMIS-5806 don't rollback TX when throwing XAER_NOTA #6168
+78
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the broker will rollback the current transaction associated with a session when it is unable to find the XID passed when rolling back. This is a pseudo optimization for the case where the current transaction has timed out and the client may be holding on to messages. However, this is a mistake because the current transaction may still be valid. One such use-case involves XA transaction recovery in a Java EE server where a dedicated recovery process may attempt to rollback a transaction that no longer exists (e.g. due to timeout, broker restart, etc.) while a valid transaction is still active and associated with the Session.
Contributor
Author
|
The full test-suite is green on this change. |
Contributor
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the broker will rollback the current transaction associated with a session when it is unable to find the XID passed when rolling back. This is a pseudo optimization for the case where the current transaction has timed out and the client may be holding on to messages.
However, this is a mistake because the current transaction may still be valid. One such use-case involves XA transaction recovery in a Java EE server where a dedicated recovery process may attempt to rollback a transaction that no longer exists (e.g. due to timeout, broker restart, etc.) while a valid transaction is still active and associated with the Session.