AVRO-1425: [Java] prioritise thread context ClassLoader over context class ClassLoader #3467
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…xt class's class loader Changes the class loading strategy in ClassUtils to first try the current thread's context class loader before falling back to the context class's class loader. This improves class loading reliability in different runtime environments. Removes the overloaded forName method that accepted a ClassLoader parameter and updates all callers to use the simplified method signature.
sleicht
changed the title
Author
|
Updated original repo which showed the issue in SpringBoot/DevTools/Avro: https://github.com/sleicht/spring-boot-devtools-with-avro |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Resolves AVRO-1425:
Changes the class loading strategy in ClassUtils to first try the current thread's context class loader before falling back to the context class's class loader. This improves class loading reliability in different runtime environments.
Removes the overloaded forName method that accepted a ClassLoader parameter and updates all callers to use the simplified method signature.
Verifying this change
This change is already covered by existing tests, such as TestSpecificData.
I also tested with a local SpringBoot application using Avro/Kafka and SpringBoot DevTools. Without the change I get a ClassCastException, and with the change it works as expected.
Documentation