Skip to content

Conversation

@patrickhayesrel
Copy link

@patrickhayesrel patrickhayesrel commented Nov 25, 2025

What is the purpose of the change

Our security scanning software has found some security issues, so we want to update the relevant version library, fixing AVRO-4213.

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

Documentation

  • Does this pull request introduce a new feature? No

@github-actions github-actions bot added Java Pull Requests for Java binding build labels Nov 25, 2025
@patrickhayesrel patrickhayesrel changed the title Upgrade jquery to 3.5.0 due to CVE-2019-11358 Upgrade jquery to 3.7.1 due to CVE-2019-11358 Nov 25, 2025
@patrickhayesrel patrickhayesrel marked this pull request as ready for review November 25, 2025 21:06
Copy link
Member

@martin-g martin-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good but someone has to test the webapp in action and verify that there are no JavaScript errors in the dev console.

@patrickhayesrel
Copy link
Author

The changes look good but someone has to test the webapp in action and verify that there are no JavaScript errors in the dev console.

I was wondering if the tests had enough coverage to determine this. Have never used this application before (just a downstream consumer via Spark) but happy to help prove this out if need be.

@martin-g
Copy link
Member

I was wondering if the tests had enough coverage to determine this.

There are no UI tests.

@RyanSkraba
Copy link
Contributor

I think this is a smart thing to do -- but it's tricky to check out the UI. I'm not sure I'm capable of doing this! Does anybody still have an idea how they work? We might need to just retire that functionality.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build Java Pull Requests for Java binding

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants