AVRO-4214: [C#] Ensure nuget packages expose SPDX license expression #3580
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kchenery
changed the title
kchenery
changed the title
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| Assert.Fail($"No .nuspec file found in package: {nupkgPath}"); | ||
| } | ||
|
|
||
| using (var stream = nuspecEntry.Open()) |
Check warning
Code scanning / CodeQL
Dereferenced variable may be null Warning test
| { | ||
| // Find the lang/csharp root (4 levels up from test binary directory: bin/Release/net8.0 -> test -> apache -> src -> csharp) | ||
| var testDir = TestContext.CurrentContext.TestDirectory; | ||
| var csharpRoot = Path.GetFullPath(Path.Combine(testDir, "..", "..", "..", "..", "..")); |
Check notice
Code scanning / CodeQL
Call to System.IO.Path.Combine Note test
martin-g
approved these changes
Nov 27, 2025
Member
|
Thank you, @kchenery ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Ensure that the C# nuget packages expose their license via SPDX expression
Verifying this change
This change added tests and can be verified as follows:
Documentation
no