Repository navigation
AVRO-3671: [C#] Preserve specific enum types - #4031
Open
sadicangel wants to merge 1 commit into
Open
sadicangel wants to merge 1 commit into
sadicangel wants to merge 1 commit into
Conversation
Materialize enums as their generated CLR types in SpecificDatumReader so unions containing integers and multiple enums retain branch identity. Returning boxed ordinals made these values indistinguishable after deserialization.
This was referenced Oct 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Fix AVRO-3671 by materializing enum values as their generated CLR types in
SpecificDatumReader.Previously, enum values were returned as boxed integer ordinals, losing branch identity in unions such as
["int", "Enum1", "Enum2"].Resolve the reader enum type through
ObjectCreatorand create the CLR enum value from the resolved reader ordinal. Existing symbol translation, default handling, generic-reader behavior, and public APIs remain unchanged.Callers relying on boxed integer enum results must now handle the generated CLR enum types.
Verifying this change
Added 21 regression cases using generated CLR types, covering:
["int", "Enum1", "Enum2"]and["null", "int", "Enum1"].Validation on Windows:
Documentation