Repository navigation
AVRO-4359: [C] Keep field and enum defaults in parsed schemas - #4032
Open
fabiocfabini wants to merge 1 commit into
Open
fabiocfabini wants to merge 1 commit into
fabiocfabini wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
The C SDK dropped the 'default' entries in the schema for records and enums. This pull request propagates the "default" field in the schema struct and rejects an enum default that isn't one of the enum's symbols.
Verifying this change
This change added tests and can be verified as follows:
test_avro_4359, that checks that field and enum defaults are present in the JSON written for a parsed and a copied schema.schema_tests/fail/enum_default_not_a_symbolfixture../build.sh clean testpasses inlang/cand valgrind checks.Documentation