Skip to content

Add staged package hashes#38311

Merged
Abacn merged 6 commits into
apache:masterfrom
tarun-google:add_package_hashes
May 28, 2026
Merged

Add staged package hashes#38311
Abacn merged 6 commits into
apache:masterfrom
tarun-google:add_package_hashes

Conversation

@tarun-google
Copy link
Copy Markdown
Contributor

Add explicit hashes along with the location, name. Runner/workers use these for validating the files before downloading.

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@tarun-google tarun-google marked this pull request as draft April 28, 2026 19:36
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a crucial security and integrity enhancement by incorporating SHA256 hashes into the metadata of staged packages. This change allows the system's runners and workers to perform a cryptographic validation of package files prior to download, ensuring that the data remains untampered and consistent with its expected state.

Highlights

  • Enhanced Package Integrity: Explicitly added SHA256 hashes to staged packages, alongside their location and name, to enable runners and workers to validate files before downloading.
  • Dataflow Package Utility Updates: Modified PackageUtil to include the SHA256 hash when creating DataflowPackage attributes for files and bytes being staged, and when overriding package names.
  • Test Coverage for Hashes: Updated PackageUtilTest to include assertions verifying that the SHA256 hash is correctly set and retrieved for staged packages.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@github-actions github-actions Bot removed the python label May 28, 2026
@tarun-google tarun-google marked this pull request as ready for review May 28, 2026 20:47
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates PackageUtil.java to set the SHA-256 hash on DataflowPackage destinations across staging methods (forFileToStage, forBytesToStage, and withPackageName). It also adds corresponding unit tests in PackageUtilTest.java to verify that the SHA-256 hash is correctly set and matches the expected file hash. There are no review comments, so no additional feedback is provided.

@github-actions
Copy link
Copy Markdown
Contributor

Assigning reviewers:

R: @Abacn added as fallback since no labels match configuration

Note: If you would like to opt out of this review, comment assign to next reviewer.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@Abacn Abacn merged commit cbab4d7 into apache:master May 28, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants