[Cherrypick] Configure JVM so that it exits upon OutOfMemoryError originating in JVM (#38567)

[Amar3tto]

Please add a meaningful description for your change here

---

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

• Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
• Update CHANGES.md with noteworthy changes.
• If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request modifies the Java container boot process in the Apache Beam SDK. It removes the automatic JVM exit behavior on OutOfMemoryError and streamlines the conditional logic for enabling heap dumps, improving the clarity and maintainability of the container startup arguments.

Highlights

• JVM Configuration: Removed the '-XX:+ExitOnOutOfMemoryError' flag from the Java container boot configuration.
• Heap Dump Logic: Refactored the heap dump configuration logic to be more concise by directly appending arguments when the option is enabled.

New Features

🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request modifies the JVM configuration in the Java SDK container boot code by removing the -XX:+ExitOnOutOfMemoryError flag and refactoring the logic for enabling heap dumps. Review feedback points out that removing the exit-on-OOM flag appears to be a mistake that contradicts the PR's objective, as it is necessary to ensure the JVM restarts rather than remaining in a degraded state after an OutOfMemoryError.

[gemini-code-assist]

The pull request title indicates that the objective is to configure the JVM to exit on OutOfMemoryError. However, this change removes the -XX:+ExitOnOutOfMemoryError flag and its associated explanatory comment. This appears to be a mistake in the cherry-pick process, as it directly contradicts the stated goal of the PR. If the intention is to ensure the JVM exits on OOM to avoid degraded states, these lines should be retained.

Suggested change

	}
	// Crash and restart instead of throwing OutOfMemoryError which may be caught by user or
	// framework code and leave things in a degraded state.
	"-XX:+ExitOnOutOfMemoryError",
	}

[Amar3tto]

Waiting for the Java PreCommit check

[Amar3tto]

testJobServerDriver (org.apache.beam.runners.flink.FlinkJobServerDriverTest) failed
runners/flink/1.17/build/test-results/test/TEST-org.apache.beam.runners.flink.FlinkJobServerDriverTest.xml
test timed out after 30000 milliseconds

[Abacn]

test failure (java unit test) not related to the PR (boot.go change)