[Release-2.74] Cherry-pick #38588 into release branch#38593
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request cherry-picks a fix from the main branch into the release-2.74 branch. The primary purpose of this change is to mitigate log spamming issues introduced by the gcsio 3.0 library by programmatically setting the logger level to SEVERE upon initialization. Highlights
New Features🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a mechanism to suppress log spam in gcsio 3.0 by setting the log level for GoogleCloudStorageImpl to SEVERE during the initialization of GoogleCloudStorage. Feedback suggests storing the logger in a static field to ensure a strong reference is maintained, preventing the log level configuration from being lost to garbage collection and making the added warning suppression unnecessary.
| return RetryDeterminer.SOCKET_ERRORS.shouldRetry(e); | ||
| } | ||
| }; | ||
| private static final AtomicBoolean overwriteLog = new AtomicBoolean(false); |
There was a problem hiding this comment.
The java.util.logging.LogManager only maintains weak references to loggers. If a logger is not held by a strong reference, it can be garbage collected, and any configuration changes (such as the log level) will be lost. To ensure the suppression persists, store the logger in a static field.
| private static final AtomicBoolean overwriteLog = new AtomicBoolean(false); | |
| private static final java.util.logging.Logger GCS_IO_LOGGER = | |
| java.util.logging.Logger.getLogger("com.google.cloud.hadoop.gcsio.GoogleCloudStorageImpl"); | |
| private static final AtomicBoolean overwriteLog = new AtomicBoolean(false); |
| } | ||
| } | ||
|
|
||
| @SuppressFBWarnings("LG_LOST_LOGGER_DUE_TO_WEAK_REFERENCE") |
There was a problem hiding this comment.
This suppression is unnecessary if a strong reference to the logger is maintained in a static field. It is better to address the underlying issue of the weak reference than to suppress the warning.
| if (overwriteLog.compareAndSet(false, true)) { | ||
| java.util.logging.Logger.getLogger("com.google.cloud.hadoop.gcsio.GoogleCloudStorageImpl") | ||
| .setLevel(java.util.logging.Level.SEVERE); | ||
| } |
There was a problem hiding this comment.
Use the static logger field to set the log level. This ensures that the SEVERE level setting is preserved even if the logger is internally recreated by the LogManager.
if (overwriteLog.compareAndSet(false, true)) {
GCS_IO_LOGGER.setLevel(java.util.logging.Level.SEVERE);
}
|
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment |
1 participant
Please add a meaningful description for your change here
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.