Skip to content

Revert "huggingface model handler for yaml - retry"#38601

Merged
derrickaw merged 1 commit into
masterfrom
revert-38451-20260511_tryHuggingFaceAgain
May 22, 2026
Merged

Revert "huggingface model handler for yaml - retry"#38601
derrickaw merged 1 commit into
masterfrom
revert-38451-20260511_tryHuggingFaceAgain

Conversation

@derrickaw
Copy link
Copy Markdown
Collaborator

Reverts #38451

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request serves to revert the recent integration of HuggingFace model handlers within Apache Beam's YAML pipelines. The changes include the removal of the HuggingFacePipelineProvider class, the deletion of related test files, and a cleanup of the Gradle build tasks that were introduced to support these specific dependencies. The overall goal is to restore the previous state of the YAML ML support and testing infrastructure.

Highlights

  • Reversion of HuggingFace Integration: This PR reverts the previously added HuggingFace model handler support for YAML pipelines, removing the associated provider class and test configurations.
  • Cleanup of Integration Test Dependencies: Removed the dedicated YAML integration test dependency installation task in the Gradle build configuration, reverting to standard GCP test dependencies.
  • Test Suite Adjustments: Removed the HuggingFace-specific YAML test file and updated the trigger file revision to reflect the changes in the test suite.
New Features

🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Ignored Files
  • Ignored by pattern: .github/workflows/** (2)
    • .github/workflows/beam_PostCommit_Yaml_Xlang_Direct.yml
    • .github/workflows/beam_PreCommit_Yaml_Xlang_Direct.yml
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the HuggingFacePipeline model handler provider from the Beam YAML SDK, including its implementation in yaml_ml.py, the corresponding integration test in runinference.yaml, and the specialized Gradle task for installing its dependencies. I have no feedback to provide as there were no review comments.

@derrickaw derrickaw requested a review from shunping May 22, 2026 13:32
@derrickaw
Copy link
Copy Markdown
Collaborator Author

@derrickaw derrickaw merged commit 70d8f7d into master May 22, 2026
108 of 111 checks passed
@derrickaw derrickaw deleted the revert-38451-20260511_tryHuggingFaceAgain branch May 22, 2026 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants