Skip to content

Handle empty batches in Python worker counters#38748

Open
goutamadwant wants to merge 2 commits into
apache:masterfrom
goutamadwant:fix/beam-38742-empty-batch-counters
Open

Handle empty batches in Python worker counters#38748
goutamadwant wants to merge 2 commits into
apache:masterfrom
goutamadwant:fix/beam-38742-empty-batch-counters

Conversation

@goutamadwant
Copy link
Copy Markdown

@goutamadwant goutamadwant commented May 30, 2026

Handles empty batched values in OperationCounters.update_from_batch without estimating a per-element byte size when the batch converter reports length zero.

This keeps empty batches from raising ZeroDivisionError in the worker counter path. It also leaves the mean byte counter unchanged because there are no elements to average.

Addresses #38742.

Testing

From sdks/python:

  • python -m pytest -q apache_beam/runners/worker/opcounters_test.py::OperationCountersTest::test_update_empty_batch
  • python -m pytest -q apache_beam/runners/worker/opcounters_test.py
  • python -m pytest -q apache_beam/typehints/batch_test.py
  • git diff --check

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a runtime error occurring in the Python worker's operation counters when encountering empty batches. By explicitly checking for a batch length of zero, the system avoids division by zero during byte size estimation and ensures that counters remain stable when no elements are present.

Highlights

  • Error Prevention: Added a check to prevent ZeroDivisionError when processing empty batches in OperationCounters.
  • Test Coverage: Introduced a new test case to verify that empty batches are handled correctly without affecting counter state.
New Features

🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request prevents a potential division-by-zero error in opcounters.py by returning early when processing empty batches, and adds a corresponding unit test. The reviewer suggests using math.nan instead of float('nan') in the new test for better performance and idiomatic Python.

Comment thread sdks/python/apache_beam/runners/worker/opcounters_test.py Outdated
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@github-actions
Copy link
Copy Markdown
Contributor

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant