-
Notifications
You must be signed in to change notification settings - Fork 4.6k
Adds support for reading at a given Delta Lake version or timestamp #39758
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
2 changes: 1 addition & 1 deletion
2
.github/trigger_files/beam_PostCommit_Java_Delta_IO_Dataflow.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
| { | ||
| "comment": "Modify this file in a trivial way to cause this test suite to run.", | ||
| "modification": 4 | ||
| "modification": 3 | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -72,7 +72,7 @@ | |
| /** | ||
| * Reads rows from a Delta Lake table. | ||
| * | ||
| * <p>Normally, it is recommended to use {@link org.apache.beam.sdk.managed.Managed#read(String)} | ||
|
Check warning on line 75 in sdks/java/io/delta/src/main/java/org/apache/beam/sdk/io/delta/DeltaIO.java
|
||
| * with {@code Managed.DELTA_LAKE} instead of directly using this transform. | ||
| */ | ||
| public static ReadRows readRows() { | ||
|
|
@@ -132,14 +132,8 @@ | |
| if (path == null) { | ||
| throw new IllegalArgumentException("Table path must be set."); | ||
| } | ||
| if (getTimestamp() != null) { | ||
| throw new UnsupportedOperationException( | ||
| "Reading from a specific timestamp is not supported yet"); | ||
| } | ||
|
|
||
| if (getVersion() != null) { | ||
| throw new UnsupportedOperationException( | ||
| "Reading from a specific version is not supported yet"); | ||
| if (getVersion() != null && getTimestamp() != null) { | ||
| throw new IllegalArgumentException("Cannot set both version and timestamp."); | ||
| } | ||
|
|
||
| Configuration conf = new Configuration(); | ||
|
|
@@ -151,7 +145,17 @@ | |
| } | ||
| Engine engine = DefaultEngine.create(conf); | ||
| Table table = Table.forPath(engine, path); | ||
| io.delta.kernel.Snapshot snapshot = table.getLatestSnapshot(engine); | ||
| Snapshot snapshot; | ||
| Long versionVal = getVersion(); | ||
| String timestampVal = getTimestamp(); | ||
| if (versionVal != null) { | ||
| snapshot = table.getSnapshotAsOfVersion(engine, versionVal); | ||
| } else if (timestampVal != null) { | ||
| long timestampMillis = java.time.Instant.parse(timestampVal).toEpochMilli(); | ||
| snapshot = table.getSnapshotAsOfTimestamp(engine, timestampMillis); | ||
| } else { | ||
| snapshot = table.getLatestSnapshot(engine); | ||
| } | ||
| StructType deltaSchema = snapshot.getSchema(); | ||
| if (deltaSchema == null) { | ||
| throw new IllegalStateException("Table schema is null."); | ||
|
|
@@ -160,7 +164,9 @@ | |
|
|
||
| return input | ||
| .apply("Create Path", Create.of(path)) | ||
| .apply("Plan Files", ParDo.of(new CreateReadTasksDoFn(hadoopConfig))) | ||
| .apply( | ||
| "Plan Files", | ||
| ParDo.of(new CreateReadTasksDoFn(hadoopConfig, getVersion(), getTimestamp()))) | ||
| .apply("Read Logical Data", ParDo.of(new DeltaSourceDoFn(hadoopConfig))) | ||
| .setRowSchema(beamSchema); | ||
| } | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is DeltaIOIT exercised by any GHA tests? Checking https://github.com/apache/beam/blob/master/.github/workflows/beam_PreCommit_Java_Delta_IO_Direct.yml it only runs
:sdks:java:io:delta:buildnot:sdks:java:io:delta:integrationTestThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's included in https://github.com/apache/beam/blob/master/.github/workflows/beam_PostCommit_Java_Delta_IO_Dataflow.yml.
Executed for the current PR here: https://github.com/apache/beam/actions/runs/31854212817/job/94935775426?pr=39758