Support Secret Manager in JdbcIO for Java, Python and YAML - #39834
Open
shunping wants to merge 3 commits into
Open
Support Secret Manager in JdbcIO for Java, Python and YAML#39834shunping wants to merge 3 commits into
shunping wants to merge 3 commits into
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
shunping
marked this pull request as ready for review
August 21, 2026 01:40
Collaborator
Author
|
r: @damccorm for java and @derrickaw for xlang and yaml. |
Contributor
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment |
damccorm
reviewed
Aug 21, 2026
damccorm
left a comment
damccorm
left a comment
Contributor
There was a problem hiding this comment.
Thanks! I think there are some improvements we can make to the documentation, but the code itself looks great
| public abstract String getReadQuery(); | ||
|
|
||
| @SchemaFieldDescription( | ||
| "Secret Manager to use for fetching secret values. For example, GoogleCloudSecretManager.") |
Contributor
There was a problem hiding this comment.
I think we need a few things to improve the docs here:
- An example of the full secret manager string and how it is used (this would go in password, not here I guess).
- A set of allowed secret managers for the default expansion service.
It might make sense to abstract this out to a small doc since it will probably show up in several places.
Contributor
There was a problem hiding this comment.
Generally, the same feedback applies to the yaml doc below.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds support for resolving database passwords securely using Secret Manager across Java, Python (cross-language), and Beam YAML for JdbcIO.
Follow-up to #39636 and #39806.
Changes