Repository navigation
Conversation
d7e9c73 to
2ed751d
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #40558 +/- ##
=============================================
+ Coverage 56.16% 79.95% +23.78%
=============================================
Files 1124 488 -636
Lines 178336 82416 -95920
Branches 1489 0 -1489
=============================================
- Hits 100170 65893 -34277
+ Misses 75645 16523 -59122
+ Partials 2521 0 -2521
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Read secrets from AWS Secrets Manager with Secret.from_json(spec, 'AwsSecretsManager') or 'type:awssecret;name:...'. Credentials and connection settings come from the --aws_* options, passed through a new Secret.apply_pipeline_options() hook (also used for --gbek). A spec can override non-credential settings such as region_name or endpoint_url.
2ed751d to
2780090
Compare
7b73c91 to
bc846b3
Compare
|
Assigning reviewers: R: @damccorm for label python. This pull request likely touches a core component ("core" label). Please review with scrutiny. Note: If you would like to opt out of this review, comment Available commands:
The PR bot will only process comments in the main thread (not review comments). |
Descriptipon
Adds
AwsSecretto retrieve secrets from AWS Secrets Manager viaSecret.from_json(spec, 'AwsSecretsManager')orSecret.parse_secret_option('type:awssecret;name:...').Changes
AwsSecret: acceptssecret_id/name/arn,version_id/version,version_stage/stage, plus any non-credentialAwsOptionssetting (e.g.region_name,endpoint_url) as a per-secret override.Secret.apply_pipeline_options(options): passed fromfrom_json()/parse_secret_option()(and--gbek).AwsSecretuses it to pull credentials and defaults fromAwsOptionslazily on workers.client_options: rejectsAwsSecretsManageras--aws_credentials_secret_manager.Part of #40528. Builds on #40547.