Fixes 260226#4738
Open
belliottsmith wants to merge 1 commit intoapache:trunkfrom
Open
Conversation
Contributor
|
+1 |
belliottsmith
force-pushed
the
fixes-260226
branch
4 times, most recently
from
848bd6f to
8506aad
Compare
ifesdjeen
reviewed
May 8, 2026
| if ((flags & NEW_PREFIX) != 0) | ||
| { | ||
| prefix = KeySerializers.routingKey.deserializePrefix(in); | ||
| fixedLength = KeySerializers.routingKey.fixedKeyLengthForPrefix(in); |
Contributor
There was a problem hiding this comment.
should be prefix instead of in
ifesdjeen
reviewed
May 8, 2026
| size += KeySerializers.routingKey.serializedSizeWithoutPrefixOrLength(e.start()); | ||
| } | ||
| if (fixedLength < 0) | ||
| size += VIntCoding.sizeOfUnsignedVInt(KeySerializers.routingKey.serializedSizeWithoutPrefixOrLength(e.start())); |
Contributor
There was a problem hiding this comment.
should this be e.end() ? (if so, I think size computation should be adjusted accordingly)
ifesdjeen
reviewed
May 8, 2026
| compressed.putShort(SIZE_OF_HEADER - 2, Shorts.checkedCast(length)); | ||
| compressed.position(SIZE_OF_HEADER); | ||
| checksum.update(compressed); | ||
| compressed.putLong(0, checksum.getValue()); |
Contributor
There was a problem hiding this comment.
Do we need to call reset here? Or do you want to accumulate checksum?
(since this is symmetrical with deser, I am assuming this is intentional, but since its unusal, I thought I'd ask)
ifesdjeen
reviewed
May 8, 2026
| int i = 2; | ||
| while (true) | ||
| { | ||
| PartitionKey next = pk(i, "ks", "tbl"); |
Contributor
There was a problem hiding this comment.
did you want to iterate through different keys there?
ifesdjeen
reviewed
May 8, 2026
| public void replay(CommandStore commandStore, ReplayMode replayMode, long minSegmentId) | ||
| { | ||
| Long2LongHashMap minSegments = new Long2LongHashMap(0); | ||
| minSegments.put(commandStore.id(), minSegmentId); |
Contributor
There was a problem hiding this comment.
minSegments is built but never passed;
pre-existing code, but got flagged because of the diff
ifesdjeen
reviewed
May 8, 2026
| this.compressor = compressor; | ||
| this.checksum = checksum; | ||
| this.channel = channel; | ||
| this.compressed = compressor.preferredBufferType().allocate(frameSize); |
Contributor
There was a problem hiding this comment.
don't we need to override close same as output?
@Override
public void close() throws IOException
{
super.close();
MemoryUtil.clean(compressed);
compressed = null;
}
belliottsmith
force-pushed
the
fixes-260226
branch
2 times, most recently
from
d9cc725 to
a6448da
Compare
- Clean Shutdown/Restart - Rebootstrap to allow nodes to rejoin consensus if they are out of sync, or did not shutdown cleanly Improve: - Improve efficiency of BTreeReducingRangeMap - DurableBefore backed by BTreeReducingRangeMap - Soft reject new transactions when a replica has a backlog of work - system_accord_debug.command_store_ops supports starting journal replay Fix: - Ensure SequentialExecutor.owner is unset only by the owner - Detect and avoid taking two AccordExecutor locks simultaneously - MaxConflicts serializer - tryToExecuteListening after replay, to handle invalidated dependencies - TxnNamedRead does not close a RowIterator, leading to native memory leaks - GetLatestDepsNack serialization - journal.readLast() did not read last - DefaultRemoteListeners not correctly synchronised - RangeTxnScanner cancellation assumes was already started - Start cfk compaction before replay - txn_graph should avoid visiting parents twice (possible if two different dependency chains connecting them in the graph) - Topology.cloneEquivalentWithEpoch should also share nodeLookup and ranges, especially to accelerate computeWaitForEpoch/computeScope - Do not invoke slowReplicaDelay or slowCoordinatorDelay during restore - Do not fail if slowReplicaDelay or slowCoordinatorDelay are invoked without knowing the transaction patch by Benedict; reviewed by Alex Petrov and Ariel Weisberg for CASSANDRA-21355
belliottsmith
force-pushed
the
fixes-260226
branch
from
a6448da to
881f217
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for sending a pull request! Here are some tips if you're new here:
Commit messages should follow the following format:
The Cassandra Jira