CASSANDRA-21344: Add gradle build support#4778
Open
dcapwell wants to merge 10 commits intoapache:trunkfrom
Open
CASSANDRA-21344: Add gradle build support#4778dcapwell wants to merge 10 commits intoapache:trunkfrom
dcapwell wants to merge 10 commits intoapache:trunkfrom
Conversation
…tform �[K ConsoleLauncher.
…a clea�[4D�[K clean JVM to avoid Gradle worker thread deadlocks, replacing the previous J�[1D�[K JavaExec implementation.
…revent�[7D�[K prevent test classes from hanging indefinitely.
| // JDK 11 runtime args (from build.xml _jvm11_arg_items) | ||
| // ------------------------------------------------------------------------- | ||
| private static List<String> jvm11Args() { | ||
| return [ |
Contributor
There was a problem hiding this comment.
Can these be read from ant? Maybe moved into some common properties files?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
i tested with a patch to accord which updates it to gradle 9. I sent this PR without that accord side just to keep things simple for the moment... i assume there will be back and forth so easier to add the accord logic once things finalize here (its just upgrading accord to gradle 9 to match cassandra)
patch written by Claude opus / reviewed / tested by me