CASSANDRA-21216/CASSANDRA-21260: Clear savedBuffer and savedNextKey in BTree.FastBuilder.reset()#4793
Open
andresbeckruiz wants to merge 1 commit intoapache:cassandra-6.0from
Conversation
…, causing ClassCastException and SSTable header corruption during schema disagreement patch by Andrés Beck-Ruiz; reviewed by Zhao Yang, Benedict Elliott Smith for CASSANDRA-21216
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Port of #4746 to the
cassandra-6.0branch.In addition to the original fix (clearing
savedBufferandsavedNextKeyfor both leaf and branch levels), the 6.0 patch also:hasRightChildon branch nodesclearSourceNode()on branch nodesInvariants.require()postcondition fromAbstractUpdater.reset()to the consolidated methodThe JVM Dtest from the original patch is not included, as the specific schema disagreement scenario it tests should not occur in 6.0.