Skip to content

Remove filter.h and replace usage with celix_filter.h#836

Merged
pnoltes merged 1 commit intomasterfrom
feature/gh-509-remove-deprecated-filter-header
Mar 4, 2026
Merged

Remove filter.h and replace usage with celix_filter.h#836
pnoltes merged 1 commit intomasterfrom
feature/gh-509-remove-deprecated-filter-header

Conversation

@pnoltes
Copy link
Contributor

@pnoltes pnoltes commented Mar 3, 2026

This PR removes the filter.h header and replaces it usage with the celix_filter.h

@codecov-commenter
Copy link

Codecov Report

❌ Patch coverage is 71.42857% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 91.42%. Comparing base (88e228f) to head (1cbe1fd).
⚠️ Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
...ndles/remote_services/topology_manager/src/scope.c 71.42% 4 Missing ⚠️
libs/framework/src/service_registry.c 33.33% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master     #836   +/-   ##
=======================================
  Coverage   91.41%   91.42%           
=======================================
  Files         235      235           
  Lines       28686    28686           
=======================================
+ Hits        26223    26225    +2     
+ Misses       2463     2461    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@PengZheng PengZheng self-requested a review March 4, 2026 03:19
Copy link
Contributor

@PengZheng PengZheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup. LGTM

typedef struct celix_filter_struct *filter_pt __attribute__((deprecated("filter is deprecated use celix_filter instead")));


CELIX_UTILS_DEPRECATED_EXPORT celix_filter_t* filter_create(const char *filterString);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall we remove corresponding implementations altogether?
Note that without these declarations the corresponding symbols are not visible outside of the shared library.

@pnoltes pnoltes merged commit e8336a8 into master Mar 4, 2026
40 of 42 checks passed
@pnoltes pnoltes deleted the feature/gh-509-remove-deprecated-filter-header branch March 4, 2026 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants