Conversation
MisterRaindrop
approved these changes
Sep 23, 2026
The Incubator releasecheck tool reports binary files in the 2.2.0-rc1
source archive. Looking at each one, only two are avoidable.
gpMgmt/demo/gppkg/data/ held a .deb and an .rpm, and they are output of
the script sitting beside them: generate_sample_gppkg.sh writes them
there in buildNative and reads them back in buildGppkg. Anyone who needs
them can run the first step, which is what its README already describes,
so they go.
The rest stay and are recorded instead:
- the sample.gppkg the gppkg behave suite installs, which has to be a
real package because the tests exercise package handling
- src/bin/pgevent/MSG00001.bin, which comes from PostgreSQL, is
referenced by pgmsgevent.rc, and is described by the README next to
it. Cloudberry never builds it: src/bin/Makefile only adds pgevent
to SUBDIRS when PORTNAME is win32
Widening the check matters as much as the deletion. It looked at class,
jar, tar, tgz, zip, exe, dll, so, gz and bz2, so none of the files the
tool found would have tripped it, including the two removed here. It now
covers deb, rpm, gppkg and bin as well, with the two kept files
allowlisted.
README.apache.md gains a section giving the reason for each allowlisted
file, and records the PAX Python API test data
(contrib/pax_storage/src/api/python3/test/test.file*). Those are
PAX-format fixtures read by paxpy_test.py, one per set of column types.
Their names carry no extension the check can match, so documenting them
is all that is possible; they are listed so the set is not invisible.
Checked by running the workflow's allowlist logic over the tree: with deb,
rpm, gppkg and bin added, every matching file is accounted for, and every
allowlist entry still exists.
Assisted-by: Claude Code
Backpatch-through: REL_2_STABLE
tuhaihe
force-pushed
the
drop-prebuilt-gppkg-samples
branch
from
September 23, 2026 14:38
5bde5ec to
0d51a99
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Incubator releasecheck tool reports binary files in the 2.2.0-rc1 source archive. Looking at each one, only two are avoidable.
gpMgmt/demo/gppkg/data/ held a .deb and an .rpm, and they are output of the script sitting beside them: generate_sample_gppkg.sh writes them there in buildNative and reads them back in buildGppkg. Anyone who needs them can run the first step, which is what its README already describes, so they go.
The rest stay and are recorded instead:
Widening the check matters as much as the deletion. It looked at class, jar, tar, tgz, zip, exe, dll, so, gz and bz2, so none of the files the tool found would have tripped it, including the two removed here. It now covers deb, rpm, gppkg and bin as well, with the two kept files allowlisted.
README.apache.md gains a section giving the reason for each allowlisted file, and records the PAX Python API test data
(contrib/pax_storage/src/api/python3/test/test.file*). Those are PAX-format fixtures read by paxpy_test.py, one per set of column types. Their names carry no extension the check can match, so documenting them is all that is possible; they are listed so the set is not invisible.
Checked by running the workflow's allowlist logic over the tree: with deb, rpm, gppkg and bin added, every matching file is accounted for, and every allowlist entry still exists.
Assisted-by: Claude Code
Backpatch-through: REL_2_STABLE
Fixes #ISSUE_Number
What does this PR do?
Type of Change
Breaking Changes
Test Plan
make installcheckmake -C src/test installcheck-cbdb-parallelImpact
Performance:
User-facing changes:
Dependencies:
Checklist
Additional Context
CI Skip Instructions