Skip to content

Backport: Honour consoleproxy.session.timeout for noVNC console sessions#13058

Open
dheeraj12347 wants to merge 1 commit intoapache:4.20from
dheeraj12347:backport-12810-consoleproxy-timeout-4.20
Open

Backport: Honour consoleproxy.session.timeout for noVNC console sessions#13058
dheeraj12347 wants to merge 1 commit intoapache:4.20from
dheeraj12347:backport-12810-consoleproxy-timeout-4.20

Conversation

@dheeraj12347
Copy link
Copy Markdown
Contributor

Description

This PR backports the console proxy/noVNC timeout fix to the 4.20 branch.

It ensures that consoleproxy.session.timeout is honoured for noVNC console
sessions, so idle sessions are cleaned up correctly and do not linger
indefinitely.

Key points:

  • Wire consoleproxy.session.timeout through the console proxy server for
    noVNC-based console sessions.
  • Apply the timeout in the WebSocket handler and GC thread so idle sessions
    are closed after the configured period.
  • Keep the change minimal and compatible with 4.20: do not introduce the
    newer sessionRequiresNewViewer API on ConsoleProxyClientParam, only
    remove the references that exist in later branches.

Related work

  • Backport of the console proxy timeout fix from the main branch.
  • Intended to address the same behaviour as the upstream change that fixed
    idle noVNC sessions not respecting consoleproxy.session.timeout.

Testing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant