veeam-control-service: fix vm pagination

[shwstppr]

Description

Currently, Veeam doesn't not support pagination for the UHAPI calls but for future support this change would allow listing resources with pagination correctly.
Only consider page in pagination for search clause https://ovirt.github.io/ovirt-engine-api-model/4.5/#_pagination

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• Build/CI
• Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

[codecov]

Codecov Report

❌ Patch coverage is 81.25000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 18.76%. Comparing base (6bc83a3) to head (859da50).
⚠️ Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
...apache/cloudstack/veeam/api/request/ListQuery.java	81.25%	1 Missing and 2 partials ⚠️

Additional details and impacted files

@@            Coverage Diff            @@
##               main   #13383   +/-   ##
=========================================
  Coverage     18.75%   18.76%           
- Complexity    17966    17969    +3     
=========================================
  Files          6160     6160           
  Lines        552578   552573    -5     
  Branches      67348    67344    -4     
=========================================
+ Hits         103660   103678   +18     
+ Misses       437512   437488   -24     
- Partials      11406    11407    +1     

Flag	Coverage Δ
uitests	3.53% <ø> (ø)
unittests	19.95% <81.25%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[winterhazel]

@blueorangutan package

[blueorangutan]

@winterhazel a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 18220

[shwstppr]

@winterhazel can this be included in the 4.23.0 milestone, or are we not accepting items for 4.23?
I'm changing the milestone for now

[winterhazel]

@winterhazel can this be included in the 4.23.0 milestone, or are we not accepting items for 4.23? I'm changing the milestone for now

@shwstppr yes, I originally intended to include this in 4.23, but probably missclicked. Thanks for noticing and moving it to the correct milestone.

[nvazquez]

Code LGTM