Skip to content

SAML SLO does not clear session cookies on logout - #14017

Draft
DaanHoogland wants to merge 1 commit into
apache:4.22from
shapeblue:ghi13997-saml-slo-session-not-cleared
Draft

SAML SLO does not clear session cookies on logout#14017
DaanHoogland wants to merge 1 commit into
apache:4.22from
shapeblue:ghi13997-saml-slo-session-not-cleared

Conversation

@DaanHoogland

Copy link
Copy Markdown
Contributor

Description

This PR...

Fixes: #13997

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • Build/CI
  • Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@codecov

codecov Bot commented Sep 1, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 17.79%. Comparing base (7ea1dca) to head (3a768c4).

Additional details and impacted files
@@            Coverage Diff            @@
##               4.22   #14017   +/-   ##
=========================================
  Coverage     17.79%   17.79%           
- Complexity    15995    15999    +4     
=========================================
  Files          5928     5928           
  Lines        534306   534310    +4     
  Branches      65383    65383           
=========================================
+ Hits          95069    95100   +31     
+ Misses       428467   428441   -26     
+ Partials      10770    10769    -1     
Flag Coverage Δ
uitests 3.69% <ø> (ø)
unittests 18.88% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@weizhouapache weizhouapache left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm

@kiranchavala

Copy link
Copy Markdown
Member

@blueorangutan package

@blueorangutan

Copy link
Copy Markdown

@kiranchavala a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan

Copy link
Copy Markdown

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 19043

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Ready

Development

Successfully merging this pull request may close these issues.

5 participants