configdrive: don't write empty network_data.json for non-ConfigDrive DHCP/DNS providers - #14020
Open
weizhouapache wants to merge 1 commit into
Open
configdrive: don't write empty network_data.json for non-ConfigDrive DHCP/DNS providers#14020weizhouapache wants to merge 1 commit into
weizhouapache wants to merge 1 commit into
Conversation
…DHCP/DNS providers ConfigDriveBuilder.writeNetworkData() unconditionally wrote network_data.json, even when needForGeneratingNetworkData() determined no NIC has the ConfigDrive NSP assigned as its Dhcp/Dns provider (e.g. networks using a VirtualRouter or a NetworkExtensionElement-based provider instead). Writing an empty-but-present file makes cloud-init's DataSourceConfigDrive believe explicit (empty) network config was supplied, which suppresses its default per-NIC DHCP auto-configuration and leaves the guest NIC administratively down with no DHCP request ever sent. Skip writing the file entirely in that case, so cloud-init falls back to its default behavior of bringing up and DHCP-configuring all available NICs.
Member
Author
|
@blueorangutan package |
|
@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 4.22 #14020 +/- ##
============================================
- Coverage 17.79% 17.79% -0.01%
- Complexity 15995 15996 +1
============================================
Files 5928 5928
Lines 534306 534306
Branches 65383 65382 -1
============================================
- Hits 95069 95067 -2
- Misses 428467 428469 +2
Partials 10770 10770
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 19041 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
ConfigDriveBuilder.writeNetworkData() unconditionally wrote network_data.json, even when needForGeneratingNetworkData() determined no NIC has the ConfigDrive NSP assigned as its Dhcp/Dns provider (e.g. networks using a VirtualRouter or a NetworkExtensionElement-based provider instead). Writing an empty-but-present file makes cloud-init's DataSourceConfigDrive believe explicit (empty) network config was supplied, which suppresses its default per-NIC DHCP auto-configuration and leaves the guest NIC administratively down with no DHCP request ever sent.
Skip writing the file entirely in that case, so cloud-init falls back to its default behavior of bringing up and DHCP-configuring all available NICs.
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?